Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: align register delegate review step #768

Merged
merged 1 commit into from
Oct 24, 2024
Merged

fix: align register delegate review step #768

merged 1 commit into from
Oct 24, 2024

Conversation

shahin-hq
Copy link
Contributor

@shahin-hq shahin-hq commented Oct 24, 2024 •
edited
Loading

Summary

Closes: https://app.clickup.com/t/86duzp142

image

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@vercel Vercel
Copy link

vercel bot commented Oct 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Oct 24, 2024 9:40am

@ItsANameToo ItsANameToo added this to the 1.17.0 milestone Oct 24, 2024
@ItsANameToo ItsANameToo merged commit b5efc3c into rc-1.17.0 Oct 24, 2024
19 of 29 checks passed
@ItsANameToo ItsANameToo deleted the fix/delegate-register-review-alignment branch October 24, 2024 10:32
shahin-hq added a commit that referenced this pull request Oct 28, 2024
@shahin-hq
fix: align register delegate review step (#768)
9383eab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samharperpittam samharperpittam samharperpittam approved these changes

@ItsANameToo ItsANameToo ItsANameToo approved these changes

@goga-m goga-m goga-m approved these changes

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shahin-hq @goga-m @ItsANameToo @samharperpittam