Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: test #769

Closed
wants to merge 20 commits into from
Closed

chore: test #769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
1bfb0e7
wip
goga-m Oct 17, 2024
a0d65d4
wip
goga-m Oct 17, 2024
1e3bc65
test: restore failing tests & coverage (#741)
goga-m Oct 17, 2024
148bf56
fix: correct amount label font size in transaction summary (#742)
goga-m Oct 17, 2024
12cd9ba
Merge branch 'develop' into fix/pending-tx-direction
goga-m Oct 17, 2024
4157fae
chore: update snapshots
shahin-hq Oct 17, 2024
1962de3
fix: enable transaction explorer link if confirmed (#746)
goga-m Oct 17, 2024
b114071
Merge branch 'develop' into fix/pending-tx-direction
goga-m Oct 17, 2024
2c145cd
chore: update snapshots
ItsANameToo Oct 18, 2024
ff50148
fix: adjust font size of wallets pagination select (#747)
shahin-hq Oct 18, 2024
1bbd512
wip
goga-m Oct 18, 2024
378c8c0
wip
goga-m Oct 18, 2024
d44b603
Merge branch 'develop' into fix/pending-tx-direction
goga-m Oct 18, 2024
a1e7915
wip
goga-m Oct 18, 2024
691694c
Merge branch 'fix/pending-tx-direction' of github.com:ArdentHQ/arkvau…
goga-m Oct 18, 2024
605ea6e
wip
goga-m Oct 18, 2024
635c8dc
wip
goga-m Oct 18, 2024
d71a8c2
wip
goga-m Oct 18, 2024
72c1280
chore: fixing e2e tests
shahin-hq Oct 24, 2024
667131b
Merge branch 'chore/test-p' into chore/test-fix
shahin-hq Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/app/components/Notifications/__snapshots__/NotificationsDropdown.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -835,15 +835,15 @@ exports[`Notifications > should open and close transaction details modal 1`] = `
Amount
</div>
<div
class="flex h-full items-center justify-center rounded px-1.5 text-base leading-5 css-xqt0aw"
class="flex h-full items-center justify-center rounded px-1.5 css-xqt0aw"
color="danger-bg"
data-testid="AmountLabel__wrapper"
>
<div
class="flex h-full items-center space-x-1"
>
<span
class="whitespace-nowrap text-sm"
class="whitespace-nowrap text-base leading-5"
data-testid="Amount"
>
- 1 DARK
Expand Down
15 changes: 14 additions & 1 deletion src/domains/dashboard/pages/Dashboard/Dashboard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { uniq } from "@ardenthq/sdk-helpers";
import { Contracts, DTO } from "@ardenthq/sdk-profiles";
import React, { useMemo, useState } from "react";
import React, {useEffect, useMemo, useState} from "react";

Check failure on line 3 in src/domains/dashboard/pages/Dashboard/Dashboard.tsx

View workflow job for this annotation

GitHub Actions / eslint (20.12.2) 

'useEffect' is defined but never used. Allowed unused vars must match /_/u
import { useTranslation } from "react-i18next";
import { EmptyBlock } from "@/app/components/EmptyBlock";
import { useWalletFilters } from "@/domains/dashboard/components/FilterWallets";
Expand All @@ -16,6 +16,9 @@
import { useActiveProfile } from "@/app/hooks";
import { WelcomeModal } from "@/domains/profile/components/WelcomeModal";
import { TransactionDetailModal } from "@/domains/transaction/components/TransactionDetailModal";
import {generatePath} from "react-router";

Check failure on line 19 in src/domains/dashboard/pages/Dashboard/Dashboard.tsx

View workflow job for this annotation

GitHub Actions / eslint (20.12.2) 

'generatePath' is defined but never used. Allowed unused vars must match /_/u
import {ProfilePaths} from "@/router/paths";

Check failure on line 20 in src/domains/dashboard/pages/Dashboard/Dashboard.tsx

View workflow job for this annotation

GitHub Actions / eslint (20.12.2) 

'ProfilePaths' is defined but never used. Allowed unused vars must match /_/u
import {useHistory} from "react-router-dom";

export const Dashboard: React.VFC = () => {
const activeProfile = useActiveProfile();
Expand Down Expand Up @@ -48,6 +51,16 @@
[activeProfile, walletsCount, profileIsSyncedWithNetwork], // eslint-disable-line react-hooks/exhaustive-deps
);

const history = useHistory();

Check failure on line 54 in src/domains/dashboard/pages/Dashboard/Dashboard.tsx

View workflow job for this annotation

GitHub Actions / eslint (20.12.2) 

'history' is assigned a value but never used. Allowed unused vars must match /_/u

// useEffect(() => {
// const p = generatePath(ProfilePaths.SendDelegateRegistration, {
// profileId: activeProfile.id(),
// walletId: "de0ad8dc-bd7c-4270-ae5f-2e4a2a71b347",
// });
// history.push(p)
// }, []);

return (
<>
<Page pageTitle={t("DASHBOARD.DASHBOARD_PAGE.TITLE")} isBackDisabled={true}>
Expand Down
8 changes: 4 additions & 4 deletions src/domains/dashboard/pages/Dashboard/__snapshots__/Dashboard.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1636,7 +1636,7 @@ exports[`Dashboard > should render 1`] = `
From
</div>
<div
class="w-30"
class="w-50 sm:w-30"
data-testid="TransactionRowAddressing__address-container"
>
<div
Expand Down Expand Up @@ -1800,7 +1800,7 @@ exports[`Dashboard > should render 1`] = `
From
</div>
<div
class="w-30"
class="w-50 sm:w-30"
data-testid="TransactionRowAddressing__address-container"
>
<div
Expand Down Expand Up @@ -1964,7 +1964,7 @@ exports[`Dashboard > should render 1`] = `
From
</div>
<div
class="w-30"
class="w-50 sm:w-30"
data-testid="TransactionRowAddressing__address-container"
>
<div
Expand Down Expand Up @@ -2128,7 +2128,7 @@ exports[`Dashboard > should render 1`] = `
From
</div>
<div
class="w-30"
class="w-50 sm:w-30"
data-testid="TransactionRowAddressing__address-container"
>
<div
Expand Down
6 changes: 3 additions & 3 deletions ...nsaction/components/MultiSignatureDetail/__snapshots__/MultiSignatureDetail.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ exports[`MultiSignatureDetail > should not broadcast if wallet is not ready to d
</div>
</div>
<div
class="mt-6 space-y-4"
class="mt-6 space-y-4 -mx-3 sm:mx-0"
>
<div
class="group flex"
Expand Down Expand Up @@ -502,15 +502,15 @@ exports[`MultiSignatureDetail > should not broadcast if wallet is not ready to d
Amount
</div>
<div
class="flex h-full items-center justify-center rounded px-1.5 text-base leading-5 css-1jspzfx"
class="flex h-full items-center justify-center rounded px-1.5 css-1jspzfx"
color="success-bg"
data-testid="AmountLabel__wrapper"
>
<div
class="flex h-full items-center space-x-1"
>
<span
class="whitespace-nowrap text-sm"
class="whitespace-nowrap text-base leading-5"
data-testid="Amount"
>
+ 1 DARK
Expand Down
6 changes: 3 additions & 3 deletions src/domains/transaction/components/MultiSignatureDetail/__snapshots__/SentStep.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ exports[`Multisignature Detail Sent Step > should render sent step %s 1`] = `
</div>
</div>
<div
class="mt-6 space-y-4"
class="mt-6 space-y-4 -mx-3 sm:mx-0"
>
<div
class="group flex"
Expand Down Expand Up @@ -550,15 +550,15 @@ exports[`Multisignature Detail Sent Step > should render sent step %s 1`] = `
Amount
</div>
<div
class="flex h-full items-center justify-center rounded px-1.5 text-base leading-5 css-xqt0aw"
class="flex h-full items-center justify-center rounded px-1.5 css-xqt0aw"
color="danger-bg"
data-testid="AmountLabel__wrapper"
>
<div
class="flex h-full items-center space-x-1"
>
<span
class="whitespace-nowrap text-sm"
class="whitespace-nowrap text-base leading-5"
data-testid="Amount"
>
- 100 DARK
Expand Down
1 change: 1 addition & 0 deletions src/domains/transaction/components/TransactionDetail/TransactionId/TransactionId.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ describe("TransactionId", () => {

render(
<TransactionId
isConfirmed
transaction={
{
explorerLink: () => "https://test.com",
Expand Down
5 changes: 3 additions & 2 deletions src/domains/transaction/components/TransactionDetail/TransactionId/TransactionId.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,10 @@ import cn from "classnames";

interface Properties {
transaction: DTO.ExtendedSignedTransactionData | DTO.ExtendedConfirmedTransactionData;
isConfirmed?: boolean;
}

export const TransactionId = ({ transaction }: Properties): ReactElement => {
export const TransactionId = ({ transaction, isConfirmed }: Properties): ReactElement => {
const { t } = useTranslation();
const { isDarkMode } = useTheme();
const { isSmAndAbove } = useBreakpoint();
Expand Down Expand Up @@ -54,7 +55,7 @@ export const TransactionId = ({ transaction }: Properties): ReactElement => {
variant="secondary"
size="icon"
className="border border-theme-secondary-300 bg-transparent p-2 hover:border-transparent dark:border-transparent dark:bg-theme-secondary-800"
disabled={!transaction.isConfirmed()}
disabled={[!isConfirmed, !transaction.isConfirmed()].every(Boolean)}
onClick={() => {
openExternal(transaction.explorerLink());
}}
Expand Down
2 changes: 1 addition & 1 deletion ...domains/transaction/components/TransactionDetail/TransactionType/TransactionType.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,6 @@ describe("TransactionType", () => {
);

expect(container).toHaveTextContent(translations.TRANSACTION_TYPES.DELEGATE_RESIGNATION);
expect(container).toHaveTextContent(hash);
expect(container).toHaveTextContent(hash.slice(0, 4));
});
});
2 changes: 1 addition & 1 deletion src/domains/transaction/components/TransactionDetailModal/TransactionDetailModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export const TransactionDetailContent = ({
return (
<DetailsCondensed>
<div className="mt-4">
<TransactionId transaction={transaction} />
<TransactionId transaction={transaction} isConfirmed={isConfirmed} />
</div>

<div className={cn("mt-6 space-y-4", containerClassname)}>
Expand Down
28 changes: 14 additions & 14 deletions ...tion/components/TransactionDetailModal/__snapshots__/TransactionDetailModal.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,15 +471,15 @@ exports[`TransactionDetailModal > should render a ipfs modal 1`] = `
Amount
</div>
<div
class="flex h-full items-center justify-center rounded px-1.5 text-base leading-5 css-xqt0aw"
class="flex h-full items-center justify-center rounded px-1.5 css-xqt0aw"
color="danger-bg"
data-testid="AmountLabel__wrapper"
>
<div
class="flex h-full items-center space-x-1"
>
<span
class="whitespace-nowrap text-sm"
class="whitespace-nowrap text-base leading-5"
data-testid="Amount"
>
- 100 DARK
Expand Down Expand Up @@ -1203,15 +1203,15 @@ exports[`TransactionDetailModal > should render a magistrate modal 1`] = `
Amount
</div>
<div
class="flex h-full items-center justify-center rounded px-1.5 text-base leading-5 css-xqt0aw"
class="flex h-full items-center justify-center rounded px-1.5 css-xqt0aw"
color="danger-bg"
data-testid="AmountLabel__wrapper"
>
<div
class="flex h-full items-center space-x-1"
>
<span
class="whitespace-nowrap text-sm"
class="whitespace-nowrap text-base leading-5"
data-testid="Amount"
>
- 100 DARK
Expand Down Expand Up @@ -2017,15 +2017,15 @@ exports[`TransactionDetailModal > should render a multi payment modal 1`] = `
Amount
</div>
<div
class="flex h-full items-center justify-center rounded px-1.5 text-base leading-5 css-xqt0aw"
class="flex h-full items-center justify-center rounded px-1.5 css-xqt0aw"
color="danger-bg"
data-testid="AmountLabel__wrapper"
>
<div
class="flex h-full items-center space-x-1"
>
<span
class="whitespace-nowrap text-sm"
class="whitespace-nowrap text-base leading-5"
data-testid="Amount"
>
- 100 DARK
Expand Down Expand Up @@ -2944,15 +2944,15 @@ exports[`TransactionDetailModal > should render a multi signature modal 1`] = `
Amount
</div>
<div
class="flex h-full items-center justify-center rounded px-1.5 text-base leading-5 css-xqt0aw"
class="flex h-full items-center justify-center rounded px-1.5 css-xqt0aw"
color="danger-bg"
data-testid="AmountLabel__wrapper"
>
<div
class="flex h-full items-center space-x-1"
>
<span
class="whitespace-nowrap text-sm"
class="whitespace-nowrap text-base leading-5"
data-testid="Amount"
>
- 100 DARK
Expand Down Expand Up @@ -3956,15 +3956,15 @@ exports[`TransactionDetailModal > should render a transfer modal 1`] = `
Amount
</div>
<div
class="flex h-full items-center justify-center rounded px-1.5 text-base leading-5 css-xqt0aw"
class="flex h-full items-center justify-center rounded px-1.5 css-xqt0aw"
color="danger-bg"
data-testid="AmountLabel__wrapper"
>
<div
class="flex h-full items-center space-x-1"
>
<span
class="whitespace-nowrap text-sm"
class="whitespace-nowrap text-base leading-5"
data-testid="Amount"
>
- 100 DARK
Expand Down Expand Up @@ -4762,15 +4762,15 @@ exports[`TransactionDetailModal > should render a transfer modal with memo 1`] =
Amount
</div>
<div
class="flex h-full items-center justify-center rounded px-1.5 text-base leading-5 css-xqt0aw"
class="flex h-full items-center justify-center rounded px-1.5 css-xqt0aw"
color="danger-bg"
data-testid="AmountLabel__wrapper"
>
<div
class="flex h-full items-center space-x-1"
>
<span
class="whitespace-nowrap text-sm"
class="whitespace-nowrap text-base leading-5"
data-testid="Amount"
>
- 100 DARK
Expand Down Expand Up @@ -5494,15 +5494,15 @@ exports[`TransactionDetailModal > should render an unlock tokens modal 1`] = `
Amount
</div>
<div
class="flex h-full items-center justify-center rounded px-1.5 text-base leading-5 css-xqt0aw"
class="flex h-full items-center justify-center rounded px-1.5 css-xqt0aw"
color="danger-bg"
data-testid="AmountLabel__wrapper"
>
<div
class="flex h-full items-center space-x-1"
>
<span
class="whitespace-nowrap text-sm"
class="whitespace-nowrap text-base leading-5"
data-testid="Amount"
>
- 100 DARK
Expand Down
9 changes: 6 additions & 3 deletions ...on/components/TransactionTable/PendingTransactionsTable/PendingTransactionsTable.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,8 @@ describe("Signed Transaction Table", () => {
/>,
);

await waitFor(() => expect(screen.getAllByTestId("TransactionRowRecipientLabel")).toHaveLength(2));
await waitFor(() => expect(screen.getAllByTestId("TransactionRowRecipientLabel")).toHaveLength(1));
await waitFor(() => expect(screen.getAllByTestId("TransactionRowAddressing__container")).toHaveLength(1));

expect(screen.getAllByTestId("TransactionRowRecipientLabel")[0]).toHaveTextContent(
translations.TRANSACTION.TRANSACTION_TYPES.MULTI_SIGNATURE,
Expand Down Expand Up @@ -814,7 +815,8 @@ describe("Signed Transaction Table", () => {
/>,
);

await waitFor(() => expect(screen.getAllByTestId("TransactionRowRecipientLabel")).toHaveLength(2));
await waitFor(() => expect(screen.getAllByTestId("TransactionRowRecipientLabel")).toHaveLength(1));
await waitFor(() => expect(screen.getAllByTestId("TransactionRowAddressing__container")).toHaveLength(1));

await userEvent.click(screen.getAllByTestId("TableRemoveButton--compact")[0]);

Expand Down Expand Up @@ -897,7 +899,8 @@ describe("Signed Transaction Table", () => {
/>,
);

await waitFor(() => expect(screen.getAllByTestId("TransactionRowRecipientLabel")).toHaveLength(2));
await waitFor(() => expect(screen.getAllByTestId("TransactionRowRecipientLabel")).toHaveLength(1));
await waitFor(() => expect(screen.getAllByTestId("TransactionRowAddressing__container")).toHaveLength(1));

expect(screen.getAllByTestId("TransactionRowRecipientLabel")[0]).toHaveTextContent(
translations.TRANSACTION.TRANSACTION_TYPES.MULTI_SIGNATURE,
Expand Down
Loading
Loading