refactor: use PSDK methods to show nonce
#800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
# Conflicts: # package.json # pnpm-lock.yaml
…refactor/nonce-extraction
…refactor/nonce-extraction
shahin-hq
commented
Nov 12, 2024
| isMultiSignatureRegistration: () => false, | ||
| isSent: () => true, | ||
| isTransfer: () => true, | ||
| isTransfer: () => true, |
There was a problem hiding this comment.
removed the duplicate
shahin-hq
commented
Nov 12, 2024
| @@ -239,9 +238,7 @@ describe("UnlockTokensModal", () => { | |||
| await act(() => vi.runOnlyPendingTimers()); | |||
|
|
|||
| if (expectedOutcome === "success") { | |||
| await waitFor(() => { | |||
| expect(screen.findByTestId("TransactionId")).resolves.toBeVisible(); | |||
| }); | |||
There was a problem hiding this comment.
simplified wait logic
shahin-hq
commented
Nov 12, 2024
| @@ -50,6 +50,7 @@ const ipfsTransactionFixture = { | |||
| isVote: () => false, | |||
| isVoteCombination: () => false, | |||
| memo: () => null, | |||
| nonce: () => BigNumber.make(6), | |||
There was a problem hiding this comment.
Nothing fishy, using 6 to avoid snapshot updates
shahin-hq
requested review from
ItsANameToo,
samharperpittam,
goga-m,
boldninja and
alexbarnsley
as code owners
ItsANameToo
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As a part of: https://app.clickup.com/t/86dv24pw0
Companion PR: ArdentHQ/platform-sdk#110
Checklist