Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: multipayment tx addressing #804

Merged
merged 8 commits into from
Nov 7, 2024
Merged

fix: multipayment tx addressing #804

merged 8 commits into from
Nov 7, 2024

Conversation

shahin-hq
Copy link
Contributor

@shahin-hq shahin-hq commented Nov 7, 2024 •
edited
Loading

Closes: https://app.clickup.com/t/86dv4f4qr

Summary

from:
scan:
image

vault:
image

to:
scan:
image

vault:
image

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@vercel Vercel
Copy link

vercel bot commented Nov 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Nov 7, 2024 3:37pm

@github-actions github-actions bot added the bugfix label Nov 7, 2024
@shahin-hq shahin-hq marked this pull request as ready for review November 7, 2024 15:37
@ItsANameToo ItsANameToo added this to the 1.18.0 milestone Nov 7, 2024
@ItsANameToo ItsANameToo merged commit 6cdb420 into develop Nov 7, 2024
27 of 39 checks passed
@ItsANameToo ItsANameToo deleted the fix/multipayment-tx-addressing branch November 7, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samharperpittam samharperpittam samharperpittam approved these changes

@ItsANameToo ItsANameToo ItsANameToo approved these changes

@goga-m goga-m Awaiting requested review from goga-m goga-m is a code owner

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.
3 participants
@shahin-hq @ItsANameToo @samharperpittam