Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: set accordions opened by default #813

Merged
merged 9 commits into from
Nov 14, 2024
Merged

refactor: set accordions opened by default #813

merged 9 commits into from
Nov 14, 2024

Conversation

patricio0312rev
Copy link
Contributor

[portfolio] default to having the list open

Summary

  • use-accordion has been refactored and it will now be opened by default.
  • This change will be reflected on wallet accordions (as seen in image), contacts list (in mobile), and custom peers accordion.
image

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@vercel Vercel
Copy link

vercel bot commented Nov 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Nov 13, 2024 4:31pm

@patricio0312rev patricio0312rev added this to the 1.19.0 milestone Nov 13, 2024
@ItsANameToo
Copy link
Contributor

some failing workflows @patricio0312rev

@ItsANameToo ItsANameToo marked this pull request as draft November 13, 2024 11:02
@patricio0312rev patricio0312rev marked this pull request as ready for review November 13, 2024 16:40
@patricio0312rev patricio0312rev mentioned this pull request Nov 13, 2024
Merged
6 tasks
@ItsANameToo ItsANameToo merged commit 683cdf7 into develop Nov 14, 2024
39 checks passed
@ItsANameToo ItsANameToo deleted the refactor/set-accordions-open-by-default branch November 14, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samharperpittam samharperpittam samharperpittam approved these changes

@ItsANameToo ItsANameToo ItsANameToo approved these changes

@goga-m goga-m Awaiting requested review from goga-m goga-m is a code owner

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
1.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@patricio0312rev @ItsANameToo @samharperpittam