fix: disable transaction type filter when there are no transactions #818
+44
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shahin-hq
changed the title
shahin-hq
requested review from
ItsANameToo,
samharperpittam,
goga-m,
boldninja and
alexbarnsley
as code owners
shahin-hq
commented
Nov 15, 2024
| @@ -148,6 +149,14 @@ export const Transactions = memo(function Transactions({ | |||
| return !hasEmptyResults || hasFilter || hasMore; | |||
| }, [activeMode, hasEmptyResults, activeTransactionType, isLoadingTransactions, hasMore]); | |||
|
|
|||
| const enableFilter = useMemo(() => { | |||
| if (isLoadingTransactions || hasFilter) { | |||
There was a problem hiding this comment.
We want to enable filter when transactions are loading or when a filter is applied - I mean by that is initially we have all possible options selected this should be understood as no filters applied, when user picks a filter it means there was at least one transaction to display, so we shouldn't disable the filter.
samharperpittam
approved these changes
Nov 15, 2024
patricio0312rev
approved these changes
Nov 15, 2024
ItsANameToo
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes: https://app.clickup.com/t/86dv5gmyt
Checklist