Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flaky transaction test #820

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Conversation

patricio0312rev
Copy link
Contributor

[tests] flaky test on transaction domain

Summary

  • The transaction fixture for the flaky unit test in src/domains/transaction/components/TransactionSuccessful/TransactionSuccessful.test.tsx has been refactored to prevent the test from randomly failing.

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Nov 14, 2024 5:51pm

@patricio0312rev patricio0312rev added this to the 1.19.0 milestone Nov 14, 2024
@ItsANameToo ItsANameToo merged commit db7f0f3 into develop Nov 15, 2024
20 checks passed
@ItsANameToo ItsANameToo deleted the fix/flaky-transaction-test branch November 15, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants