Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat: improve takeoff and fly-to commands #1283

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

rmackay9
Copy link
Contributor

This PR includes two small enhancements to the chat module:

  1. Instructions to the assistant have been updated to increase the chance that it will set the "frame" field correctly.
  2. Add a new get_location_plus_offset function to help the assistant more quickly and easily respond to commands like, "fly 100m North". Without this the assistant tries to work out the calculation itself each time and this leads to some failures

Both these changes have been tested and work. Below are some screen shots from a recent test.
image

I should add that during testing I saw the chat window apparently freeze up twice probably waiting for responses from the Assistant that never arrived. I haven't seen these freezes before but I assume they are unrelated to these changes and have added this to the issues list.

@peterbarker peterbarker merged commit 3e10e1d into ArduPilot:master Dec 15, 2023
1 check passed
@rmackay9
Copy link
Contributor Author

Thanks!

@rmackay9 rmackay9 deleted the chat-latlon-fix branch December 15, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants