Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ardupilot_ros: removed cartographer dependency #4

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

snktshrma
Copy link

No description provided.

@Ryanf55 Ryanf55 added the ros1 label Aug 11, 2023
@Ryanf55
Copy link
Collaborator

Ryanf55 commented Sep 4, 2023

Could you explain your reason you intend to remove usage of cartographer? We use cartographer in ROS 2.

@snktshrma
Copy link
Author

Hi @Ryanf55 ! Actually adding cartographer as a dependency to package.xml was causing some errors while building the package. So I resorted to remove it from package.xml dependencies and added instructions to install it manually in readme through cartographer’s rosinstall script.

@Ryanf55
Copy link
Collaborator

Ryanf55 commented Sep 4, 2023

Hi @Ryanf55 ! Actually adding cartographer as a dependency to package.xml was causing some errors while building the package. So I resorted to remove it from package.xml dependencies and added instructions to install it manually in readme through cartographer’s rosinstall script.

Ok. Would you be able to share the error you get?

@snktshrma
Copy link
Author

@Ryanf55, The error was because rosdep was not able to find cartographer_ros package. That's why i had to remove it from here.

@Ryanf55
Copy link
Collaborator

Ryanf55 commented Sep 4, 2023

cartographer_ros

Which ROS1 distribution is this for?

@snktshrma
Copy link
Author

@Ryanf55, as per official docs, it is for melodic as well as noetic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants