Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images: fix misplaced image file extensions #6362

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

rsaxvc
Copy link
Contributor

@rsaxvc rsaxvc commented Nov 1, 2024

Rename file extensions to match file formats and update references accordingly.

@Hwurzburg
Copy link
Contributor

no impact to wiki rendering....I was hard pressed to find why this makes a difference, every graphics editing or conversion program I have simply ignores the file extension and uses the file's internal data header....what program does this make a difference to, out of curiosity? since it has no impact on the wiki and is technically correct I am merging...

@Hwurzburg Hwurzburg merged commit 237a3dc into ArduPilot:master Nov 2, 2024
5 checks passed
@rsaxvc rsaxvc deleted the image_extension_cleanup branch November 3, 2024 02:34
@rsaxvc
Copy link
Contributor Author

rsaxvc commented Nov 3, 2024

Gimp - depends how file is specified.

Eye of Mate - "Error interpreting JPEG image file (Not a JPEG file: starts with 0x89 0x50)", but Eye of Gnome works.

Android Photos app - saved files from wiki render correctly but shown with "0.0MP"

find . -iname "*.jpeg" -exec jpegoptim {} \+ and find . -iname "*.png" -exec pngcrush -ow {} \; now works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants