Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not pin span in url for playground trace details slideover #5200

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

cephalization
Copy link
Contributor

correct.span.linkage.mov

In addition to removing selectedSpanNodeId from the url on playground page, fixing the original issue; I also added a key to the playground page component in order to reset the page's state when the spanId segment of the url changes. This is somewhat of a sledgehammer approach compared to selectively resetting state based on the span url, but it catches many more edge cases.

Resolves #5193

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 25, 2024
@cephalization cephalization merged commit 7f41824 into main Oct 28, 2024
7 checks passed
@cephalization cephalization deleted the cephalization/5193-update-trace-link-on-run branch October 28, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
Status: Done
2 participants