Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bubble errors up from nested invocation parameter schema transforms #5202

Merged

Conversation

cephalization
Copy link
Contributor

@cephalization cephalization commented Oct 25, 2024

resolves #5198
This allows errors to be displayed in the playground UI when the invocation parameters are totally incorrect on the span

image

This is what happens when I set invocation params to "'hi'" in the database

This allows errors to be displayed in the playground UI when the invocation parameters are totally incorrect on the span
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 25, 2024
@cephalization cephalization merged commit 6ccb0c0 into main Oct 28, 2024
7 checks passed
@cephalization cephalization deleted the cephalization/5198-invocation-param-parsing-warning branch October 28, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] invocation parameter parsing from a span to playground does not properly surface parsing errors
2 participants