Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(playground): add response_format to invocation parameters #5239

Merged
merged 2 commits into from
Oct 31, 2024
Merged

feat(playground): add response_format to invocation parameters #5239

merged 2 commits into from
Oct 31, 2024

Conversation

RogerHYang
Copy link
Contributor

@RogerHYang RogerHYang commented Oct 31, 2024 •
edited
Loading

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 31, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Oct 31, 2024
@axiomofjoy
Copy link
Contributor

I think we also need to plumb through in the invocation_parameters class method for OpenAI.

@RogerHYang RogerHYang merged commit 2ea4100 into main Oct 31, 2024
35 checks passed
@RogerHYang RogerHYang deleted the response-format branch October 31, 2024 19:23
@mikeldking mikeldking mentioned this pull request Oct 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axiomofjoy axiomofjoy axiomofjoy approved these changes

Assignees
No one assigned
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
phoenix
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[playground][gql] support for output schema (e.g. JSON mode)
2 participants
@RogerHYang @axiomofjoy