Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Only show providers if dependencies are installed #5251

Merged
merged 6 commits into from
Nov 1, 2024

Conversation

anticorrelator
Copy link
Contributor

@anticorrelator anticorrelator commented Nov 1, 2024

resolves #5116

GenerativeProvider will now have a dependencies field and dependencies_installed field that can be used to filter down to show only available providers

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 1, 2024
@@ -84,6 +85,8 @@
from phoenix.server.api.types.UserApiKey import UserApiKey, to_gql_api_key
from phoenix.server.api.types.UserRole import UserRole

initialize_playground_clients()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this once inside create_app?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question, I think probably yes

Copy link
Contributor

@axiomofjoy axiomofjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add anthropic?

@anticorrelator
Copy link
Contributor Author

Add anthropic?

I think this is added already @axiomofjoy

@anticorrelator anticorrelator merged commit 2fd2948 into main Nov 1, 2024
36 checks passed
@anticorrelator anticorrelator deleted the dustin/filter-playground-providers branch November 1, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[playground][gql] filter down the list of providers depending on whether or not client packages are intalled
2 participants