feat: Add authorization overlays #5695
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
mikeldking
reviewed
Dec 12, 2024
Comment on lines
+17
to
+20
| valueFrom: | ||
| secretKeyRef: | ||
| name: phoenix-secret | ||
| key: secret-key |
There was a problem hiding this comment.
Maybe we default this to just a long string but leave the note? Otherwise it will break... It's what I did with railway... I know it's sorta risky but it at least gets people started (similar to having postgres password)
mikeldking
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4516
Add overlays to enable auth, while we suggest a pattern to use a kubernetes secret the user needs to manage getting secrets into their system securely on their own