feat(experiments): add experiment run filter to compare experiments page #5738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
axiomofjoy
force-pushed
the
xander/experiment-run-filter
branch
from
b54ce9b to
f921977
Compare
dosubot
bot
added
the
size:XXL
axiomofjoy
changed the title
RogerHYang
reviewed
Dec 19, 2024
Comment on lines
650
to
653
| elif isinstance(ast_operator, ast.In): | ||
| return lambda left, right: operators.contains_op(right, left) | ||
| elif isinstance(ast_operator, ast.NotIn): | ||
| return lambda left, right: operators.not_contains_op(right, left) |
There was a problem hiding this comment.
Ideally, we should use TextContains, otherwise it turns into LIKE and special characters like % would need escaping.
There was a problem hiding this comment.
Good catch, I addressed with escaping since its smaller change to the current implementation. 10c5fd1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds filtering via query DSL to compare experiments page.
resolves #5681