test id & signature

ArkEcosystem · Nov 11, 2024 · f69c147 · f69c147
1 parent e554c7a
commit f69c147
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 10 deletions.
diff --git a/tests/Concerns/Deserialize.php b/tests/Concerns/Deserialize.php
@@ -9,7 +9,7 @@
 
 trait Deserialize
 {
-    protected function assertDeserialized(array $expected, array $keys, int $network = 30): object
+    protected function assertDeserialized(array $expected, array $keys): object
     {
         $actual = Deserializer::new($expected['serialized'])->deserialize();
         $data   = $actual->data;
@@ -51,15 +51,6 @@ protected function assertSameTransactions(array $expected, array $actual, array
             }
         }
 
-        // Signatures and IDs are not deterministic
-        unset($expected['id']);
-        unset($expected['signature']);
-        unset($expected['signatures']);
-
-        unset($actual['id']);
-        unset($actual['signature']);
-        unset($actual['signatures']);
-
         $this->assertSame($expected, $actual);
     }
 

diff --git a/tests/Unit/Transactions/DeserializerTest.php b/tests/Unit/Transactions/DeserializerTest.php
@@ -74,10 +74,12 @@ public function it_should_deserialize_a_validator_resignation_signed_with_a_pass
     private function assertTransaction(array $fixture): AbstractTransaction
     {
         $actual = $this->assertDeserialized($fixture, [
+            'id',
             'nonce',
             'gasPrice',
             'gasLimit',
             'contractId',
+            'signature',
         ]);
 
         $this->assertTrue($actual->verify());