This repository has been archived by the owner on Oct 1, 2021. It is now read-only.
refactor: add focus trap to modal component #663
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://app.clickup.com/t/1je5e0d
When a modal is opened, the first focusable element should receive the focus. Tabbing should focus the next sibling and should keep the focus on elements in the modal.
When a modal is closed, the focus should come back to the element used to trigger the modal.
Saying that, this PR improves the modal component to take care of those behaviors.
Checklist
icons.html
file and checked if my newly added icon is shown correctly (if necessary)