Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guildwars2 #49

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Guildwars2 #49

wants to merge 1 commit into from

Conversation

AsherGlick
Copy link
Owner

An initial commit for gw2. Some key usability features are still missing from the calculator in order for me to justify such a big new set of files to be merged into dev or mainline.

This includes code to gather item databases and recipe databases from the GW2 API, however it does not yet support Mystic forge recipes as those are not available on the API, possibly due to their dynamic nature.

  • Dynamic rendering of items.
  • Chunking of item images and item lists (this meta-item image is 24.6MB after compression. Sending that whole thing all the time could be a major slowdown.
  • Efficient cache policy and hash suffixes to prevent as much re-downloading as possible.
  • Splitting out the compressed json into its own file so it can be cached separately from the calculator page.
  • Some sort of nonlinear scale for sankey chart. Previous to this I imagined it could be solved with a simple is_currency value that would scale some things. But now it looks like it might be better off to go with a dynamic logarithm instead.
  • Speedups to generation, hopefully most of the scaling slowdowns for this are because of the minification process of the json data. This step can be eliminated completely if the generated json is already compressed. Without these the amount of time taken to generate the entire website increases significantly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant