Tracking when files are copied/moved not just updated #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vreelb to see if this works on windows as well. |
|
Unfortunately it does not appear to work on Windows. |
|
FWIW it is still likely useful to merge this if it solves this on Linux, as Windows is no worse off with this change than before. |
|
That's unfortunate to hear. Some research into the windows file APIs make it seem like this is impossible on windows because that type of data is not tracked by the OS. I wonder how other systems handle it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a file is moved into a folder then the current cache invalidation detection wont see it if its modified time is not updated as well. This adds a check on mtime (modified) as well as ctime (change) to see if either of these values are newer then the current cached files.