-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Startpage redesign into 2 columns #266
base: master
Are you sure you want to change the base?
Conversation
43f9e33
to
ee10154
Compare
This is very cool, thanks! :D Regarding the carousel, it seems like the location of the current 5 watches would be an ideal fit for a carousel (and they could/should be part of the carousel) |
Regarding your point on Matrix on the "Proven building block" paragraph being too technical, maybe we should move it to be the last paragraph? |
Done! Good idea. |
yeah, sometimes things come together like puzzle pieces. I'll try to implement that. Sounds not much harder than slice the banner into 5 watches (we could only show 3 for mobile then) and playing a slide show above each individual watch. |
This sounds like a rabbit hole (changing the content of the watches in web ?). Maybe an easier approach could be to just have a bunch of static images of watches with pre-integrated screenshots and cycle through these instead ? |
That sounds a bit easier. But than we could only have fade-in/over transitions. My goal was to have a masked area for the screens and then slide images to the left or right. To hint at out UI gestures :P |
startpage-slider-2023-03-08_00.48.58.mp4 |
I find it a bit too fast now, I feel that with a little bit more time it would get a bit less overwhelming to the user. nit: Our screenshots have a black ring leftover from the asteroid-launcher CircleMaskShader https://github.com/AsteroidOS/asteroid-launcher/blob/master/qml/compositor/compositor.qml#L258 on a nice it smooths out the borders of the screen (kinda like an antialiasing) but on screenshots this creates an undesirable artifact. I wonder if there's something simple we could do about this like post-processing screenshots by reducing their circle a tiny bit ? Now that we are no longer using the nice top picture you had done, I feel it would be good to have screenshots for AoD (the one you had selected was perfect for this) and I feel that the screenshot of the homepage should be the default style, with the watchface that comes in stock. One thing that's unclear to me (I should test it but it's getting late and I won't get to it tonight) is when the slideshow stops. eg: on your video, on a small screen, it stops at the Music app and one never gets to see the weather app. Also the "extreme" apps (far right and left) like timer or agenda here are only visible for such a short amount of time that it makes it very hard to see them. I think the carousel should wait a bit longer when getting to an edge. |
Yepp, Agreed. I should have stated what is to evaluate in this state of the draft :P
|
Ok, this has gotten 4x more complicated due to the 4 sensible viewport sizes we (and everyone else in the industry) uses to switch between
My hardcoded pure css implementation now needs to have those four cases in each class. And manually adaptively set (smaller) values as the screen gets smaller. I might at some point be able to refactor the whole code to "group" the four
Now, what is not adapted to the 4 viewports yet
This curve is defined by actions at percentage values over the runtime of the animation. And by the width the aformationed action "pushes" the slides to the left. To not spend hours testing stuff back and forth, we would no need to agree on the amount of screenshots. Because most of the things depend on that. On that is done, i can adapt all viewport sizes to scroll to the correct length. And adapt the curves to behave the same.
Mind that the negative margin-left on all slides is what slides/pulls the whole cue of floating screenshots to the left. Out of view. This is how the above mentioned implementations look currently when quenching a browser window:
startpage-slider-2023-03-08_15.11.16.mp4 |
Will be adressed in next commit, after having added 5 more shots. For a total of 20.
Jupp, agreed. Will cut one or two pixels more narrow. The originals i took are 400px from catfish. So i got lots of margin for that.
Absolutely! The upside now is that we got the rainbow complete :P But i agree, a more informative order with black AoDs and such mixed is to be prefered. How about removing the Alarm Clock. its not really pretty still imo
That is mitigated in last comment/commit. where the shot/slide sizes are a bit adapted to viewport size. I would not a make them any smaller or give more overlap than now. Next step to achive uniform behaviour over all viewport sizes is to agree on amount of shots, max duration of the animation (=not to slow on large VP but not too fast on small VP. Since Duration will be adaptive to help show all shots on much narrower screen) and the "Curve".
Yepp, needs decision on how it should look on one VP, then unifiy that behaviour over all VPs. As described in explaining what produces that "curve" in last comment. |
After polishing the slideshow according to above discussion
This is how it behave now start-page-2023-04-07_20.46.20.mp4 |
- Remove invisible shadow - Remove screenshots and add about-container class div to wrap the paragraph divs - Add two column layout and adaptively set about-text min-height - Sort Proven building blocks paragraph to last position Signed-off-by: Timo Könnecke [email protected]
- Add 24 screenshots - Add Slideshow CSS components - Remove banner and add slideshow to index.md - Adapt screenshot sizes to 4 viewport sizes - Unify length and speed of slideshow over all viewport width - Add shadow to screenshots Signed-off-by: Timo Könnecke [email protected]
f22f5db
to
28c00be
Compare
@FlorentRevest @eLtMosen Given that the carousel is still under discussion, would it make sense to split this PR into one for the carousel and one for the 2 columns? Especially since the 2 columns seems to be agreed upon? |
Oh I'm sorry I dropped the ball on this one! 😔 it completely slipped my mind. Among the comments I would have left for the carousel would be that we never get to see the rightmost images unfortunately, and that I would prefer if when the carousel hits the rightmost images, it would stop there for a second and then jump back to the beginning rather than slowly circle in the opposite direction With that being said, this is bike-shedding and it's been going on for too long, so if you guys disagree, feel free to just go ahead and merge it anyway. If it ends up bothering me way too much, I'll figure something out ahah. |
While trying to update the 2x2 screenshots in light of 2.0 release i became aware of several issues:
This PR
Pushing this as a draft for now. This PR misses a replacement for the screenshots. Which is highly desirable to keep the informative function of those screenshots.
It is planned to add an automatic slide show in size of one screenshot. Where many screenshots get slid-in from the side (to imitate or hint at our UI gesture possibly) or fade-over in place in fashion of a carousel.
Desktop (max content width is capped at 990px)
Tablet:
Phone