-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
analog-nihil-dark,analog-nihil-light: add two watch faces #133
base: master
Are you sure you want to change the base?
Conversation
Sorry for the late reply! :) Thank you for the contribution! Just a couple of comments:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this great addition to the community watchfaces!
The brand name use should be avoided for legal reasons. A quick idea for a rename in case you are not an english native speaker, is to translate it to your language. Or find an idiom or analogy (like zilch, nil, nuttin.. etc) in case we stay in english :D
My requested changes are removing the QtGraphicalEffects import and adding yourself to the contributors list. You can do that in pseudonym (i.e. use your username) as long as you use that name across your contributions to AsteroidOS. Just in case you do not want to reveal your real name.
The svg optimization is not a blocker for this PR.
Thanks again for your contribution and sorry for the long wait for a review.
analog-nothing-dark/usr/share/asteroid-launcher/watchfaces-img/analog-nothing-dark-hour.svg
Outdated
Show resolved
Hide resolved
analog-nothing-dark/usr/share/asteroid-launcher/watchfaces/analog-nothing-dark.qml
Outdated
Show resolved
Hide resolved
bdf54ce
to
abf6b97
Compare
Addressed. analog-nothing is now analog-nihil, and the import is gone. |
Add a faithful recreation of the stylish clock widget design by Nothing, as seen here:
Comes in light and dark versions.