Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

analog-nihil-dark,analog-nihil-light: add two watch faces #133

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

turretkeeper
Copy link

Add a faithful recreation of the stylish clock widget design by Nothing, as seen here:
Clock widget

Comes in light and dark versions.

@FlorentRevest
Copy link
Member

Sorry for the late reply! :)

Thank you for the contribution! Just a couple of comments:

  • Nothing seems to be a trademark, could you remove references to their brand ? we prefer avoiding referring to other brands ;)
  • Since you're not using any of the QtGraphicalEffects, those import QtGraphicalEffects 1.15 lines aren't necessary and should make the watchface loading a tad bit faster ;)

Copy link
Member

@eLtMosen eLtMosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this great addition to the community watchfaces!

The brand name use should be avoided for legal reasons. A quick idea for a rename in case you are not an english native speaker, is to translate it to your language. Or find an idiom or analogy (like zilch, nil, nuttin.. etc) in case we stay in english :D

My requested changes are removing the QtGraphicalEffects import and adding yourself to the contributors list. You can do that in pseudonym (i.e. use your username) as long as you use that name across your contributions to AsteroidOS. Just in case you do not want to reveal your real name.

The svg optimization is not a blocker for this PR.

Thanks again for your contribution and sorry for the long wait for a review.

@turretkeeper turretkeeper changed the title analog-nothing-dark,analog-nothing-light: add two watch faces analog-nihil-dark,analog-nihil-light: add two watch faces Sep 24, 2024
@turretkeeper
Copy link
Author

Sorry for the late reply! :)

Thank you for the contribution! Just a couple of comments:

* Nothing seems to be a trademark, could you remove references to their brand ? we prefer avoiding referring to other brands ;)

* Since you're not using any of the QtGraphicalEffects, those `import QtGraphicalEffects 1.15` lines aren't necessary and should make the watchface loading a tad bit faster ;)

Addressed. analog-nothing is now analog-nihil, and the import is gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants