Simplify installation #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pyproject.toml should tell build systems that torch needs to be available _before_ installation so there's no issues with the torch_scatter
|
@benedekrozemberczki the point of this PR is to make it so torch can be an installation requirement (therefore is installed before trying to install any other requirements, namely Not sure why CI didn't run, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the pyproject.toml to tell build systems that torch needs to be available before installation so there's no issues with the torch_scatter. It switches from setup.py to a completely declarative setup in setup.cfg. At the same time, it switches to the standard
src/layout to work with this modern setupDepends on
pyproject.tomlto make installations easier rusty1s/pytorch_scatter#266