-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editing-support): add mini-operators
plugin
#857
Conversation
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
-- NOTE: this will override the default AstroNvim keybinding for opening neo-tree. | ||
-- the default prefix would be g, but this will also override some bindings. | ||
local prefix = "<Leader>o" | ||
|
||
local mappings = { | ||
n = { | ||
[prefix] = { | ||
name = "Text edit operators", | ||
}, | ||
}, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I think overriding the neo-tree default is a no-go. @AstroNvim/astrocommunity-maintainers Any ideas?
- Similar to other reviews: Lets use the same method for mappings as we do most of the other plugins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree not to override default neo-tree operator
mini-operators
mini-operators
plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will take over this PR and get it ready for merge
8328f16
to
6d20a7c
Compare
6d20a7c
to
9f17c9b
Compare
📑 Description
Making this a draft PR, because i am unsure which binding would match it neatly. I left there also an note on the source code.