Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editing-support): add mini-operators plugin #857

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

manuuurino
Copy link
Contributor

📑 Description

Making this a draft PR, because i am unsure which binding would match it neatly. I left there also an note on the source code.

Copy link

github-actions bot commented Apr 9, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

Comment on lines 1 to 11
-- NOTE: this will override the default AstroNvim keybinding for opening neo-tree.
-- the default prefix would be g, but this will also override some bindings.
local prefix = "<Leader>o"

local mappings = {
n = {
[prefix] = {
name = "Text edit operators",
},
},
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I think overriding the neo-tree default is a no-go. @AstroNvim/astrocommunity-maintainers Any ideas?
  2. Similar to other reviews: Lets use the same method for mappings as we do most of the other plugins.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree not to override default neo-tree operator

@manuuurino manuuurino changed the title feat(editing-support): add mini-operators feat(editing-support): add mini-operators plugin Apr 10, 2024
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will take over this PR and get it ready for merge

@mehalter mehalter marked this pull request as ready for review April 11, 2024 20:44
@mehalter mehalter requested a review from Uzaaft April 11, 2024 20:44
@mehalter mehalter merged commit 37d6048 into AstroNvim:main Apr 12, 2024
12 checks passed
This was referenced Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants