Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go): modify the build callback to avoid freezing on go.nvim installation #980

Merged
merged 1 commit into from
May 21, 2024

Conversation

rami3l
Copy link
Contributor

@rami3l rami3l commented May 21, 2024

📑 Description

Currently, Neovim will freeze when installing/updating go.nvim due to the synchronous callback trying to install relevant Golang CLI devtools. This PR stops that from happening via an asynchronous callback instead.

cc ray-x/go.nvim#433

ℹ Additional Information

I have locally tested this change on my machine using the following override:

  -- astrocommunity.pack.go
  {
    "ray-x/go.nvim",
    build = function() require("go.install").update_all() end,
  },

Copy link

github-actions bot commented May 21, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Uzaaft Uzaaft changed the title fix(pack/go): modify the build callback to avoid freezing on go.nvim installation fix(go): modify the build callback to avoid freezing on go.nvim installation May 21, 2024
@Uzaaft Uzaaft merged commit 06fbacf into AstroNvim:main May 21, 2024
12 checks passed
@rami3l rami3l deleted the patch-1 branch May 21, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants