Rewrote scheduling code #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added check for if POWER_BI_TIMEZONE is already defined
sku in the case that the update resource capacity fails
Mainly for debugging info and will most likely be removed prior to a real release
It non longer will try to schedule evertime the plugin is loaded but will setup the wp_events once when the settings page is saved There is an issue with scheduling todays events that needs to be looked into. Basically it will run todays events that have passed which when piled on top of one another could cause an issue. The capacity update is robust enough to overcome this but the suspend and resume are not.
On the settings page added display of next scheduled event for each action
|
One thing I noticed is there isn't deactivate or activate functionality. There should be a deactivate function to remove scheduled events upon deactivation of the plugin. Then the activation function should reschedule these. This is an easy thing to add. Again this code is not tested as I do not have an azure BI account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not tested because I do not have an azure bi account.
This is a rewrite of the scheduling code.
The scheduler no longer needs to run each time the plugin is loaded.
All events are scheduled when the settings page is saved.
Also the UI for the settings has been updated.
Updated to include four events per day. This is now easily changeable by adding or removing from this array:
private $day_variations = array('_1', '_2', '_3', '_4');
Added a display of the next schedule for each event:
Next scheduled resume @ Tuesday, December 24, 2019, 0:00
Next scheduled suspend @ Tuesday, December 24, 2019, 0:10