Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update faucet #193

Open
wants to merge 3 commits into
base: devnet
Choose a base branch
from
Open

Update faucet #193

wants to merge 3 commits into from

Conversation

DmitriVT
Copy link
Contributor

@DmitriVT DmitriVT commented Nov 15, 2024 •
edited
Loading

closes #192

@DmitriVT DmitriVT requested a review from hrls November 15, 2024 14:41
@DmitriVT DmitriVT self-assigned this Nov 15, 2024
hrls
hrls requested changes Nov 15, 2024
View reviewed changes
pallets/faucet/src/lib.rs
// Ensure faucet has enough balance
ensure!(faucet_balance >= amount, Error::<T>::NoAmountToTransfer);

T::Currency::transfer(&account_id, &who, amount, ExistenceRequirement::AllowDeath)?;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allow Death?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yeah, I mixed up the meaning of the two flags. Changed

runtime/src/lib.rs Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrls hrls hrls requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@DmitriVT DmitriVT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update faucet pallet
2 participants
@DmitriVT @hrls