Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AddressCoinBalanceChart and ChartWidget components #44

Merged
merged 1 commit into from
May 1, 2024

Conversation

r8bywork
Copy link

@r8bywork r8bywork commented Apr 30, 2024

Description and Related Issue(s)

Fixes the issue with "No data" appearing in the coin balance history (#36).

Proposed Changes

Updated the AddressCoinBalanceChart and ChartWidget components to resolve the issue. The changes ensure that the coin balance history is correctly displayed without showing "No data".

Breaking or Incompatible Changes

There are no breaking or incompatible changes introduced by this pull request.

Additional Information

This fix improves the user experience by ensuring accurate coin balance history display without any misleading "No data" messages.

Checklist for PR author

  • I have tested these changes locally.
  • I added tests to cover any new functionality, following this guide
  • Whenever I fix a bug, I include a regression test to ensure that the bug does not reappear silently.
  • If I have added, changed, renamed, or removed an environment variable, I have updated the list of environment variables in the documentation and made the necessary changes to the validator script according to the guide

- Fix issue with "No data" appearing in coin balance history (#36)
@r8bywork r8bywork self-assigned this Apr 30, 2024
@r8bywork r8bywork added the bug Something isn't working label Apr 30, 2024
@r8bywork r8bywork linked an issue Apr 30, 2024 that may be closed by this pull request
@r8bywork r8bywork added bug Something isn't working and removed bug Something isn't working labels Apr 30, 2024
@r8bywork r8bywork removed the request for review from alwayscolorblind April 30, 2024 22:33
@r8bywork r8bywork merged commit 715c5dc into atleta May 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"No data" in coin balance history
2 participants