Update release.yml to restore MacOS artifacts #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks. Let's see if this works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Build "Restore MacOS artifacts"
Purpose of change
Seems like the
ModuleNotFoundError: No module named 'pkg_resources'build error is a documented problem when dealing withsetuptools. This PR addresses #148 by installing a specific version of the dependency as part of the MacOS dependency chain.Describe the solution
By adding the
setuptoolsdependency, the error no longer occurs and both the curses and tiles github jobs are back to green:Describe alternatives you've considered
Testing
After applying the changes, I have managed to build MacOS artifacts in my own test branch here: https://github.com/DazedNConfused-/Cataclysm-EOD/releases/tag/eod-experimental-2024-04-10-2230
Additional context