Pocket Knife - Hephaestus Soul #20081
Open
+168
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!review |
FluffyGhoster
requested changes
Oct 19, 2024
|
Resolving issues thanks to Fluffy making my code much nicer. |
alsoandanswer
requested changes
Oct 19, 2024
Comment on lines
+359
to
+362
| /obj/item/toy/balloon/syndicate = 4, | ||
| /obj/item/material/knife/butterfly/switchblade/pocket_knife = 2.5, | ||
| /obj/item/material/knife/butterfly/switchblade/pocket_knife/blue = 2.5, | ||
| /obj/item/material/knife/butterfly/switchblade/pocket_knife/red = 2.5 |
There was a problem hiding this comment.
Spawn chance should be much lower and should be shared with normal butterfly knives.
Not only this has a higher chance of rolling, it's also rolling three times
Comment on lines
+204
to
+208
| /obj/item/material/knife/butterfly/switchblade/pocket_knife/blue | ||
| icon_state = "pocketblue" | ||
|
|
||
| /obj/item/material/knife/butterfly/switchblade/pocket_knife/red | ||
| icon_state = "pocketred" |
There was a problem hiding this comment.
Don't manually create colored variants, use recolorable code (see : screwdrivers)
alsoandanswer
requested changes
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new pocket knife and some alternative versions.
Adds a pocket butter knife, a unique item restricted to Hephaestus crew.