Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable autocomplete for recaptcha input #1203

Merged
merged 1 commit into from
Jul 12, 2023
Merged

fix: disable autocomplete for recaptcha input #1203

merged 1 commit into from
Jul 12, 2023

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Jun 21, 2023

All Submissions:

Changes proposed in this Pull Request:

Ensures that the input element used by reCAPTCHA is not autofilled by the browser.

Note that I wasn't able to replicate the autofilling issue, but adding the autocomplete="off" attribute should prevent the field from getting autofilled by most browsers. See also Automattic/newspack-plugin#2517

Closes 1204751246381643/1204838932706810.

How to test the changes in this Pull Request:

  1. Turn on autofill for your browser and ensure that there is a saved email address that will automatically autofill any email inputs.
  2. Test on master first, with reCAPTCHA v3 enabled in the Connections wizard. Submit a newsletter signup block form. Does it fail?
  3. Check out this branch and test again. The form should submit without errors.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo added bug Something isn't working [Status] Needs Review labels Jun 21, 2023
@dkoo dkoo requested a review from a team as a code owner June 21, 2023 22:57
@dkoo dkoo self-assigned this Jun 21, 2023
@dkoo dkoo mentioned this pull request Jun 21, 2023
Merged
6 tasks
leogermani
leogermani approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@leogermani leogermani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also could not reproduce the issue. But the change looks ok

@dkoo dkoo merged commit 5d899c0 into master Jul 12, 2023
@dkoo dkoo deleted the fix/disable-autofill-for-recaptcha branch July 12, 2023 22:18
matticbot pushed a commit that referenced this pull request Jul 20, 2023
@semantic-release-bot
chore(release): 1.67.3-alpha.1 [skip ci]
dda1f9a 
## [1.67.3-alpha.1](v1.67.2...v1.67.3-alpha.1) (2023-07-20)

### Bug Fixes

* disable autocomplete for recaptcha input ([#1203](#1203)) ([5d899c0](5d899c0))
* **subscription-block:** css on tablet/mobile preview ([#1218](#1218)) ([d0539cc](d0539cc))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.67.3-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Aug 7, 2023
@semantic-release-bot
chore(release): 1.67.3 [skip ci]
7f80192 
## [1.67.3](v1.67.2...v1.67.3) (2023-08-07)

### Bug Fixes

* disable autocomplete for recaptcha input ([#1203](#1203)) ([5d899c0](5d899c0))
* **subscription-block:** css on tablet/mobile preview ([#1218](#1218)) ([d0539cc](d0539cc))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 1.67.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leogermani leogermani leogermani approved these changes

Assignees

@dkoo dkoo

Labels
bug Something isn't working released on @alpha released [Status] Approved Ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkoo @matticbot @leogermani