Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(styling): list styles #1621

Merged
merged 1 commit into from
Aug 22, 2024
Merged

feat(styling): list styles #1621

merged 1 commit into from
Aug 22, 2024

Conversation

adekbadek
Copy link
Member

@adekbadek adekbadek commented Aug 16, 2024

All Submissions:

Changes proposed in this Pull Request:

Building on #1335, adds margin to the li element, so the indentation is preserved.

Before After
image image

How to test the changes in this Pull Request:

  1. On trunk, create a new newsletter and insert an unordered and an order list, ensure list items content is long enough to wrap to next line
  2. Preview the email – observe the content wrapping does not preserve the indentation
  3. Switch to this branch, observe the indentation is preserved

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Building on #1335, adds margin to the li element, so the indentation is
preserved.
@adekbadek adekbadek merged commit e9ea4dd into trunk Aug 22, 2024
7 of 8 checks passed
@adekbadek adekbadek deleted the feat/email-list-styles branch August 22, 2024 06:35
@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.2.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@matticbot
Copy link
Contributor

🎉 This PR is included in version 3.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants