-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: automatically disable guest authors #3345
Open
leogermani
wants to merge
3
commits into
trunk
Choose a base branch
from
feat/automatically-disable-guest-authors
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leogermani
added
the
[Status] Needs Review
The issue or pull request needs to be reviewed
label
Aug 15, 2024
adekbadek
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described, but I wonder if the migration won't be too involving.
github-actions
bot
added
[Status] Approved
The pull request has been reviewed and is ready to merge
and removed
[Status] Needs Review
The issue or pull request needs to be reviewed
labels
Aug 16, 2024
leogermani
added
Work In Progress
and removed
[Status] Approved
The pull request has been reviewed and is ready to merge
labels
Sep 20, 2024
leogermani
added
[Status] Needs Review
The issue or pull request needs to be reviewed
and removed
Work In Progress
labels
Oct 22, 2024
adekbadek
approved these changes
Oct 24, 2024
@@ -78,6 +83,13 @@ public static function initialize() { | |||
|
|||
// Hide author email on the frontend, if it's a placeholder email. | |||
\add_filter( 'theme_mod_show_author_email', [ __CLASS__, 'should_display_author_email' ] ); | |||
|
|||
// Make sure we check again if the site has guest authors evey hour. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
Suggested change
// Make sure we check again if the site has guest authors evey hour. | |
// Make sure we check again if the site has guest authors every hour. |
github-actions
bot
added
[Status] Approved
The pull request has been reviewed and is ready to merge
and removed
[Status] Needs Review
The issue or pull request needs to be reviewed
labels
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
After the introduction of the Guest Contributor role, we now want to be more proactive and disable CAP's guest authors if the site is not using the feature yet.
CAP's Guest Authors feature will be disabled by default if there are no Guest Authors in the site. If you want to force enabling it, add the NEWSPACK_ENABLE_CAP_GUEST_AUTHORS constant to your wp-config.php file.
How to test the changes in this Pull Request:
wp option get newspack_check_site_has_cap_guest_authors
should returnyes
wp option delete newspack_check_site_has_cap_guest_authors
no
define( 'NEWSPACK_ENABLE_CAP_GUEST_AUTHORS', true );
to wp-configTesting CRON
no
Other information: