Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starter-content): e2e improvements; removal CLI command #3498

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

adekbadek
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Small improvements to how starter content is handled.

How to test the changes in this Pull Request:

  1. Generate starter content with wp newspack setup
  2. Remove it with wp newspack remove-starter-content – observe it's removed
  3. Add NEWSPACK_IS_E2E environment variable and generate starter content again
  4. Observe all posts have the same image and content, and the titles are prefixed with the post index

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@adekbadek adekbadek added the [Status] Needs Review The issue or pull request needs to be reviewed label Oct 25, 2024
@adekbadek adekbadek requested a review from a team as a code owner October 25, 2024 12:23
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants