Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ia): dashboard newsletters settings link #3515

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

miguelpeixe
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Somewhere around changes in #3490 the settings URL got changed and the dashboard link never got updated. This PR updates the dashboard link to point to the correct page.

How to test the changes in this Pull Request:

  1. While on the epic branch, confirm on Newspack -> Dashboard that clicking on the Newsletters -> Settings goes to a missing page
  2. Checkout this branch and confirm that the link points to the correct page

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@miguelpeixe miguelpeixe added the [Status] Needs Review The issue or pull request needs to be reviewed label Nov 1, 2024
@miguelpeixe miguelpeixe self-assigned this Nov 1, 2024
@miguelpeixe miguelpeixe requested a review from a team as a code owner November 1, 2024 18:55
@github-actions github-actions bot added [Status] Approved The pull request has been reviewed and is ready to merge and removed [Status] Needs Review The issue or pull request needs to be reviewed labels Nov 1, 2024
@miguelpeixe miguelpeixe merged commit 8ae081d into epic/ia Nov 1, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Approved The pull request has been reviewed and is ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants