-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GHA Workflow for validating issues #1547
Conversation
Generated by 🚫 dangerJS |
You can test the changes in simplenote-ios from this Pull Request by:
|
ec66928
to
a39f40a
Compare
@@ -6,7 +6,7 @@ on: | |||
|
|||
jobs: | |||
check-labels-on-issues: | |||
uses: Automattic/dangermattic/.github/workflows/reusable-check-labels-on-issues.yml@iangmaia/gha-labels-on-issues-check | |||
uses: Automattic/dangermattic/.github/workflows/reusable-check-labels-on-issues.yml@trunk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you feel about pinning to a version?
Or... maybe using trunk
is cool because it will auto-update?
Then again, auto-updates can backfire if something was to change.
🤔 🤔 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, it will auto-update for now. My plan is to keep it in trunk until we ship a first stable version of Dangermattic after all the API changes we've been doing, then we can move to a @v1
pinning instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, right. I didn't realize Dangermattic wasn't v1 yet. I should have checked...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a39f40a
to
4e8d551
Compare
This PR reimplements our current Issues check done in Peril with a GHA workflow. It uses the reusable workflow implemented on Automattic/dangermattic#31.
How to test
This is a bit hard to test as GHA Issue events are only triggered for workflows already on the main branch, and a complete test can be done only once this PR is merged.
I've tested it with a fork on my account. Feel free to create issues and play around with the labels on my forked project: https://github.com/iangmaia/woocommerce-android/