GHA Workflow for validating issues #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iangmaia
added
the
tooling
Generated by 🚫 dangerJS |
You can test the changes in simplenote-ios from this Pull Request by:
|
iangmaia
force-pushed
the
iangmaia/gha-labels-on-issues-check
branch
from
ec66928
to
a39f40a
Compare
mokagio
reviewed
Feb 5, 2024
| @@ -6,7 +6,7 @@ on: | |||
|
|
|||
| jobs: | |||
| check-labels-on-issues: | |||
| uses: Automattic/dangermattic/.github/workflows/reusable-check-labels-on-issues.yml@iangmaia/gha-labels-on-issues-check | |||
| uses: Automattic/dangermattic/.github/workflows/reusable-check-labels-on-issues.yml@trunk | |||
There was a problem hiding this comment.
How do you feel about pinning to a version?
Or... maybe using trunk is cool because it will auto-update?
Then again, auto-updates can backfire if something was to change.
🤔 🤔 🤔
There was a problem hiding this comment.
Yep, it will auto-update for now. My plan is to keep it in trunk until we ship a first stable version of Dangermattic after all the API changes we've been doing, then we can move to a @v1 pinning instead.
There was a problem hiding this comment.
Ah, right. I didn't realize Dangermattic wasn't v1 yet. I should have checked...
This was referenced Feb 8, 2024
iangmaia
force-pushed
the
iangmaia/gha-labels-on-issues-check
branch
from
a39f40a
to
4e8d551
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reimplements our current Issues check done in Peril with a GHA workflow. It uses the reusable workflow implemented on Automattic/dangermattic#31.
How to test
This is a bit hard to test as GHA Issue events are only triggered for workflows already on the main branch, and a complete test can be done only once this PR is merged.
I've tested it with a fork on my account. Feel free to create issues and play around with the labels on my forked project: https://github.com/iangmaia/woocommerce-android/