Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SwiftLint configuration in the project and run it on CI #1554

Merged
merged 6 commits into from
Feb 27, 2024

Conversation

iangmaia
Copy link
Contributor

Description

This PR sets up SwiftLint as CocoaPods dependency and runs it on CI using the command run-swiftlint.

The main changes:

  • .swiftlint.yml file update and definition of the SwiftLint version to use.
  • Use of run-swiftlint command from a8c-ci-toolkit-buildkite-plugin in a new Buildkite step.
  • Configure SwiftLint via CocoaPods.
  • Configure project to run SwiftLint as a Build Phase.
  • Fix the currently found violations in the codebase.
  • Remove the SwiftLint Rake and Hound configurations.

Testing Details

Make sure CI is 🟢

@iangmaia iangmaia added the tooling Related to anything that supports the building & maintaining of the project. label Feb 26, 2024
@iangmaia iangmaia self-assigned this Feb 26, 2024
@iangmaia iangmaia changed the title Update SwiftLint project and CI configuration Update SwiftLint project and CI configurations Feb 26, 2024
@iangmaia iangmaia changed the title Update SwiftLint project and CI configurations Update SwiftLint configuration in the project and run it on CI Feb 26, 2024
@dangermattic
Copy link
Collaborator

3 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

You can test the changes in simplenote-ios from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr1554-f63e68a-018de6d8-fa8d-440b-a3d8-399e9c190964 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI tests failure is a long standing issue and has nothing to do with these changes.

:shipit:

@iangmaia iangmaia merged commit c9558aa into trunk Feb 27, 2024
9 of 14 checks passed
@iangmaia iangmaia deleted the iangmaia/swiftlint branch February 27, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Related to anything that supports the building & maintaining of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants