Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passkeys: UI interaction feedback and errors #1604

Draft
wants to merge 27 commits into
base: feature/passkeys
Choose a base branch
from

Conversation

charliescheer
Copy link
Contributor

Fix

Soooo... the first PR for implementing passkeys into iOS has some user interaction issues. None of the errors are handled, so if it fails it just does nothing.... and the registration and auth processes happen over time and can be slow, but the UI give no activity indication, and isn't locked in anyway so you can keep poking and clicking all over the place... not great....

So I have fixed that in this PR. Here you will see:

  • When registering a passkey a full screen modal spinner appears
  • if registration succeeds you see a success message
  • if registration fails you see an error
  • When logging in using passkeys the ui locks and the sign in button activity indicator animates
  • if auth fails you will see an alert

Test

Registration:

  1. Log into an account with email and password
  2. go to Settings and tap on Add Passkey authentication. Confirm that you see a spinner
  3. When the passkey modal pops up, dismiss it. Confirm you see an error message
  4. Tap on the app passkey button again and this time complete the registration. Confirm you see a success message (note if you already have a passkey registered you will need to delete it from the server

Auth:

  1. log out of your account
  2. tap on login -> Login with passkeys
  3. enter an email address that isn't valid. Confirm no login attempt is done and you get an alert that the email is invalid
  4. enter the email address you registered with. When the passkey modal pops up, dismiss it. You should see an alert and the ui should unlock
  5. Try logging in again with the correct email and this time confirm the passkey auth. Confirm you get logged in and the ui unlocks

Review

(Required) Add instructions for reviewers. For example:

Only one developer and one designer are required to review these changes, but anyone can perform the review.

Release

(Required) Add a concise statement to RELEASE-NOTES.txt if the changes should be included in release notes. Include details about updating the notes in this section. For example:

RELEASE-NOTES.txt was updated in d3adb3ef with:

Added markdown support

If the changes should not be included in release notes, add a statement to this section. For example:

These changes do not require release notes.

charliescheer and others added 27 commits June 5, 2024 12:03
@dangermattic
Copy link
Collaborator

1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

You can test the changes in simplenote-ios from this Pull Request by:

  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr1604-b0c9b8c-019018f1-bb58-43fa-930e-3d141910390e on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@charliescheer charliescheer force-pushed the charlie/passkey-implementation branch from 7e524e0 to 23ed723 Compare July 1, 2024 17:56
Base automatically changed from charlie/passkey-implementation to feature/passkeys July 2, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants