Delete note if the content is completely removed

[charliescheer]

Fix

It was brought up in an issue for SNMac, that if a note is empty we leave it in the note list and it would be nice if they deleted themselves. I thought about this for a bit and decided that I agreed, but I wanted to make sure that we only moved the notes to the trash, that way the history for the note still exists and a user could reclaim the lost content if they wanted. So in this PR I have done that.

iOS already deleted new notes that were empty, so this PR simply updates that logic to not exclude existing notes. If a user deletes all the content in a note and then exits the editor the note will be moved to the trash. This is the same behavior as in apple notes.

Test

Confirm new notes with content are not deleted

1. Create a new note and add some content to it
2. Close the editor

• Confirm your new note continues to exist
• Relaunch the app and confirm your new note was saved to the DB

Confirm new notes without content are deleted

1. Create a new note, do not add content to it
2. Close the editor

• Confirm that your new note was deleted

Confirm an existing note that has all it's content removed, will be deleted

1. Go to a note you don't mind losing.
2. Delete all of the text content in the note
3. Exit the editor.

• Confirm that your note is deleted from the notes list

4. Go to the note trash, find the top note labeled "New Note..." restore it
5. Go to the regular notes list, open the note you restored, go to the notes history

• Confirm you can restore that notes history

Review

(Required) Add instructions for reviewers. For example:

Only one developer and one designer are required to review these changes, but anyone can perform the review.

Release

(Required) Add a concise statement to RELEASE-NOTES.txt if the changes should be included in release notes. Include details about updating the notes in this section. For example:

These changes do not require release notes.

[dangermattic]

	1 Warning
⚠️	This PR is assigned to the milestone 4.56. This milestone is due in less than 4 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in Simplenote Prototype Build by scanning the QR code below to install the corresponding build.

	App Name	Simplenote Prototype Build
	Build Number	pr1665-c71dc66-0192a2aa-7300-4562-958e-e55644f721b7
	Version	4.54
	Bundle ID	com.codality.NotationalFlow.Alpha
	Commit	c71dc66
	App Center Build	Simplenote - Installable Builds #387

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[jleandroperez]

@charliescheer I'm not 100% sure this change is what we want: you'd loose the ability to use the Revision History slider to recover the content.

The note would end up in Trash, so you'd need to manually recover, before you're able to use the version slider.

WDYT?