-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tooling] Use bot for release management git operations #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iangmaia
added
the
tooling
Related to anything that supports the building & maintaining of the project.
label
Oct 24, 2024
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in Simplenote Prototype Build by scanning the QR code below to install the corresponding build.
|
…ations with write access
…ping only version bump
iangmaia
force-pushed
the
iangmaia/use-trusted-mac-agents-for-releases
branch
from
October 24, 2024 19:55
716405c
to
b6124db
Compare
mokagio
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to wordpress-mobile/WordPress-iOS#23697 👍
I'll apply the suggestion to remove the shebang flags from WordPress-iOS when I'll work on the final bit of release-in-CI automation in the next few days.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
PR adding Simplenote Android to ReleasesV2 already using the
use-bot-for-git
script: Automattic/simplenote-android#1688See paaHJt-6EP-p2 for more details.
What it does
This PR updates the release pipelines to use the
use-bot-for-git
script to use a bot account for git operations, avoiding the need for SSH deploy keys with write permission.Note: this PR also upgrades Xcode to
16.1-rc.1
.How to test
We'll fully run the release pipelines in the next release cycle once this is merged.
To test it, I've commented out a few side effects from
start_code_freeze
on b6124db and ran it directly on Buildkite (setting the env varPIPELINE=release-pipelines/start-code-freeze.yml
) with this resulting build.