feat(dev-env): add PHP 8.3 image #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjangda
reviewed
Sep 8, 2023
sjinks
force-pushed
the
add/php83
branch
2 times, most recently
from
f9cd203
to
8797fea
Compare
rebeccahum
requested changes
Oct 17, 2023
| export const DEV_ENVIRONMENT_PHP_VERSIONS: Record< string, PhpImage > = { | ||
| 8.1: { image: 'ghcr.io/automattic/vip-container-images/php-fpm:8.1', label: '8.1 (recommended)' }, | ||
| 8.2: { | ||
| image: 'ghcr.io/automattic/vip-container-images/php-fpm:8.2', |
There was a problem hiding this comment.
We should mark 8.2 as recommended at this point now given that we're moving towards everyone being on it now, yeah?
rebeccahum
reviewed
Oct 20, 2023
| [ '7.4', DEV_ENVIRONMENT_PHP_VERSIONS[ '7.4' ].image ], | ||
| [ '8.0', DEV_ENVIRONMENT_PHP_VERSIONS[ '8.0' ].image ], | ||
| [ '8.1', DEV_ENVIRONMENT_PHP_VERSIONS[ '8.1' ].image ], | ||
| [ '8.2', DEV_ENVIRONMENT_PHP_VERSIONS[ '8.2' ].image ], |
There was a problem hiding this comment.
Do we need to add 8.3 to the test?
rebeccahum
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the PHP 8.3 image to the dev environment.
It depends on Automattic/vip-container-images#526
Steps to Test
vip dev-env createworks and sets the specified PHP versionvip dev-env updateworks and sets the specified PHP versionvip dev-env createand...updateshow the prompt like this: