-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dev-env): add PHP 8.3 image #1485
Conversation
f9cd203
to
8797fea
Compare
export const DEV_ENVIRONMENT_PHP_VERSIONS: Record< string, PhpImage > = { | ||
8.1: { image: 'ghcr.io/automattic/vip-container-images/php-fpm:8.1', label: '8.1 (recommended)' }, | ||
8.2: { | ||
image: 'ghcr.io/automattic/vip-container-images/php-fpm:8.2', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should mark 8.2 as recommended at this point now given that we're moving towards everyone being on it now, yeah?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
[ '7.4', DEV_ENVIRONMENT_PHP_VERSIONS[ '7.4' ].image ], | ||
[ '8.0', DEV_ENVIRONMENT_PHP_VERSIONS[ '8.0' ].image ], | ||
[ '8.1', DEV_ENVIRONMENT_PHP_VERSIONS[ '8.1' ].image ], | ||
[ '8.2', DEV_ENVIRONMENT_PHP_VERSIONS[ '8.2' ].image ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add 8.3 to the test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Description
This PR adds the PHP 8.3 image to the dev environment.
It depends on Automattic/vip-container-images#526
Steps to Test
vip dev-env create
works and sets the specified PHP versionvip dev-env update
works and sets the specified PHP versionvip dev-env create
and...update
show the prompt like this: