Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dev-env): migration from vipdev.lndo.site to vipdev.site #851

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sjinks
Copy link
Member

@sjinks sjinks commented Aug 7, 2024

No description provided.

Copy link

github-actions bot commented Aug 7, 2024

Trivy Scan Report

ghcr.io/automattic/vip-container-images/dev-tools:0.9 (alpine 3.20.3)

No vulnerabilities found.

@rebeccahum
Copy link
Contributor

How do we make sure we don't break things for existing dev-env users who aren't running on the latest CLI? 😬

@sjinks
Copy link
Member Author

sjinks commented Aug 19, 2024

@rebeccahum Images are updated independently of VIP CLI.

For the existing environments, images are re-pulled every two weeks. For new environments, they are pulled on the first start.

The idea is to merge this PR and ship Automattic/vip-cli#1984, say, in a month.

@rinatkhaziev
Copy link
Contributor

For the existing environments, images are re-pulled every two weeks. For new environments, they are pulled on the first start.

@sjinks Right, but then it means someone on the old version will download the new image and the migration routine will run for them?

@sjinks
Copy link
Member Author

sjinks commented Aug 27, 2024

@rinatkhaziev

https://github.com/Automattic/vip-container-images/pull/851/files#diff-ad8cc8dcf9efb7506300a53b2cf5754bf370da1daa148bf33304572c6a8050f7R206

The migration routine will start if the new domain is *.vipdev.site and the siteurl mentions vipdev.lndo.site. That is, the migration will never happen for the old versions of VIP CLI.

@rinatkhaziev
Copy link
Contributor

@rebeccahum ideally we should test a bit :)

@rebeccahum
Copy link
Contributor

@rinatkhaziev testing? don't know her

@rinatkhaziev
Copy link
Contributor

Testing, please meet @rebeccahum. Rebecca, please meet Testing, our good friend.

@sjinks
Copy link
Member Author

sjinks commented Sep 9, 2024

@rebeccahum @rinatkhaziev is it ok to merge this? Or are you still having fun with Testing?

@rebeccahum
Copy link
Contributor

@sjinks Haven't reached out to Testing yet, are you able to?

@sjinks
Copy link
Member Author

sjinks commented Sep 9, 2024

I actually did :-) (like a month ago)

This is what we were doing:

  1. Create, start, and stop a new environment (it should be in vipdev.lndo.site)
  2. Update Lando config (~/.local/share/vip/lando/config.yml) and set domain: vipdev.site
  3. Make sure that no other environment is running and there's no proxy container hanging around. If they are, kill them.
  4. Restart the environment; it should say "Migrating from vipdev.lndo.site to vipdev.site, please stand by…"
  5. Make sure that the new ....vipdev.site URL works.

@rinatkhaziev
Copy link
Contributor

I'm gonna try to break it, stay tuned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants