Add and apply Rector #107
Merged
Add and apply Rector #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No intentional changes in behaviour - mostly whitespace changes to ensure more compliance with coding standards.
RemoveUnusedForeachKeyRector
RecastingRemovalRector
RemoveNullPropertyInitializationRector
SimplifyUselessVariableRector
RemoveNonExistingVarAnnotationRector
RemoveNullTagValueNodeRector
RemoveUnusedPrivatePropertyRector
RemoveUnreachableStatementRector
RemoveUnusedVariableAssignRector
RemoveDeadReturnRector
SimplifyIfReturnBoolRector
UnnecessaryTernaryExpressionRector
SimplifyIfElseToTernaryRector
CombineIfRector
SimplifyBoolIdenticalTrueRector
SimplifyRegexPatternRector
CompleteDynamicPropertiesRector
ShortenElseIfRector
ExplicitReturnNullRector
AbsolutizeRequireAndIncludePathRector
ChangeArrayPushToArrayAssignRector
IssetOnPropertyObjectToPropertyExistsRector
SwitchNegatedTernaryRector
CountArrayToEmptyArrayComparisonRector
SimplifyEmptyCheckOnEmptyArrayRector
LocallyCalledStaticMethodToNonStaticRector
EncapsedStringsToSprintfRector
ExplicitPublicClassMethodRector
SymplifyQuoteEscapeRector
NewlineAfterStatementRector
These changes were missed during the merge conflict resolution.
GaryJones
force-pushed
the
feature/add-rector
branch
from
24d45aa
to
32e2d8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://getrector.com/ is a tool for PHP development that can help rewrite code to meet certain rules, such as tidying up code when different minimum versions of PHP are supported or following common or best practices around code quality, dead code, coding style, and more.
I've applied each PHP ruleset, and then different levels of the prepared sets in different commits - for review, these would be much easier to see the similar changes, that reviewing all the changes at once.
One notable change not covered here is the addition of type declarations.
I believe there is no change in functionality from this PR.