address warnings and errors

AutonomyLab · Oct 4, 2022 · d75d41c · d75d41c
1 parent de253b6
commit d75d41c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/include/create/serial_query.h b/include/create/serial_query.h
@@ -68,6 +68,7 @@ namespace create {
 
     public:
       SerialQuery(std::shared_ptr<Data> data, bool install_signal_handler = true);
+      virtual ~SerialQuery() = default;
   };
 }  // namespace create
 

diff --git a/include/create/serial_stream.h b/include/create/serial_stream.h
@@ -73,6 +73,7 @@ namespace create {
         std::shared_ptr<Data> data,
         const uint8_t& header = create::util::STREAM_HEADER,
         bool install_signal_handler = true);
+      virtual ~SerialStream() = default;
 
   };
 }  // namespace create

diff --git a/src/create.cpp b/src/create.cpp
@@ -160,10 +160,10 @@ namespace create {
       prevTicksRight = totalTicksRight;
 
       // Handle wrap around
-      if (fabs(ticksLeft) > 0.9 * util::V_3_MAX_ENCODER_TICKS) {
+      if (std::abs(ticksLeft) > 0.9 * util::V_3_MAX_ENCODER_TICKS) {
         ticksLeft = (ticksLeft % util::V_3_MAX_ENCODER_TICKS) + 1;
       }
-      if (fabs(ticksRight) > 0.9 * util::V_3_MAX_ENCODER_TICKS) {
+      if (std::abs(ticksRight) > 0.9 * util::V_3_MAX_ENCODER_TICKS) {
         ticksRight = (ticksRight % util::V_3_MAX_ENCODER_TICKS) + 1;
       }
 
@@ -373,7 +373,7 @@ namespace create {
         min > 59)
       return false;
 
-    uint8_t cmd[4] = { OC_DATE, day, hour, min };
+    uint8_t cmd[4] = { OC_DATE, static_cast<uint8_t>(day), hour, min };
     return serial->send(cmd, 4);
   }