Module to import Account Moves #1022
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivantodorovich
suggested changes
Mar 12, 2020
| <field name="type">general</field> | ||
| </record> | ||
| </data> | ||
| </openerp> |
There was a problem hiding this comment.
Hmmm. I'm not sure the module should create journals.
What if they already have them? Or if they don't want them?
Also, if we were to load them.. this should be noupdate=1.
But I really think we shouldn't
There was a problem hiding this comment.
The creation of journals is a request in this task
| _description = 'Import Account Moves import' | ||
|
|
||
| file = fields.Binary('File', required=True) | ||
| journal = fields.Selection(JOURNALS, 'Journal', required=True) |
There was a problem hiding this comment.
Why not using a journal_id = fields.Many2one() field?
There was a problem hiding this comment.
For making the import easy because there are 39 journals and we have 5 fils to import with only 5 journals.
|
Also, we need to retarget the PR to AwesomeFoodCoops:dev branch. In this project everything goes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.