Skip to content

Commit

Permalink
INT - moved resolver builder to utils for reusability
Browse files Browse the repository at this point in the history
  • Loading branch information
vivekschauhan committed Nov 13, 2024
1 parent 19098ff commit 7b3df22
Show file tree
Hide file tree
Showing 2 changed files with 45 additions and 32 deletions.
40 changes: 40 additions & 0 deletions pkg/util/dialer.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (

"github.com/Axway/agent-sdk/pkg/util/log"
"golang.org/x/net/proxy"
gr "google.golang.org/grpc/resolver"
)

const (
Expand Down Expand Up @@ -167,3 +168,42 @@ func (d *dialer) createConnectRequest(ctx context.Context, targetAddress, sniHos
}
return req.WithContext(ctx)
}

type customGRPCResolverBuilder struct {
addr string
authority string
schema string
}

func CreateCustomGRPCResolverBuilder(addr, authority, scheme string) gr.Builder {
return &customGRPCResolverBuilder{
addr: addr,
authority: authority,
schema: scheme,
}
}

func (b *customGRPCResolverBuilder) Build(target gr.Target, cc gr.ClientConn, _ gr.BuildOptions) (gr.Resolver, error) {
cc.UpdateState(gr.State{Endpoints: []gr.Endpoint{
{
Addresses: []gr.Address{
{
Addr: b.addr,
ServerName: b.authority,
},
},
},
}})
return &nopResolver{}, nil
}

func (b *customGRPCResolverBuilder) Scheme() string {
return b.schema
}

type nopResolver struct {
}

func (*nopResolver) ResolveNow(gr.ResolveNowOptions) {}

func (*nopResolver) Close() {}
37 changes: 5 additions & 32 deletions pkg/watchmanager/manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import (
"github.com/Axway/agent-sdk/pkg/watchmanager/proto"
"github.com/google/uuid"
"google.golang.org/grpc"
gr "google.golang.org/grpc/resolver"
)

// NewManagerFunc func signature to create a Manager
Expand Down Expand Up @@ -88,7 +87,11 @@ func (m *watchManager) createConnection() (*grpc.ClientConn, error) {
logrusStreamClientInterceptor(m.options.loggerEntry),
),
grpc.WithUserAgent(m.cfg.UserAgent),
grpc.WithResolvers(&builder{m.cfg.Host, m.cfg.Port}),
grpc.WithResolvers(
util.CreateCustomGRPCResolverBuilder(
fmt.Sprintf("%s:%d", m.cfg.Host, m.cfg.Port),
m.cfg.Host,
"https")),
}

m.logger.
Expand All @@ -99,36 +102,6 @@ func (m *watchManager) createConnection() (*grpc.ClientConn, error) {
return grpc.NewClient(address, grpcDialOptions...)
}

type builder struct {
host string
port uint32
}

func (b *builder) Build(target gr.Target, cc gr.ClientConn, _ gr.BuildOptions) (gr.Resolver, error) {
cc.UpdateState(gr.State{Endpoints: []gr.Endpoint{
{
Addresses: []gr.Address{
{
Addr: fmt.Sprintf("%s:%d", b.host, b.port),
ServerName: b.host,
},
},
},
}})
return &nopResolver{}, nil
}

func (b *builder) Scheme() string {
return b.host
}

type nopResolver struct {
}

func (*nopResolver) ResolveNow(gr.ResolveNowOptions) {}

func (*nopResolver) Close() {}

func (m *watchManager) getDialer(targetAddr string) (util.Dialer, error) {
if m.options.singleEntryAddr == "" && m.options.proxyURL == "" {
return nil, nil
Expand Down

0 comments on commit 7b3df22

Please sign in to comment.