APIGOV-28932 - remove jfrog call and use agentstate #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dgghinea
commented
Oct 8, 2024
dgghinea
commented
- Removes jfrog call and uses the agentstate from the DA/TA resource(which are updated by separate jobs(for on-prem) and agents-controller(for SaaS)
- in case the state is not found, we simply log a warning with it(this can happen the first time the agent starts)
dgghinea
requested review from
jcollins-axway,
dfeldick,
sbolosan,
vivekschauhan and
alrosca
as code owners
vivekschauhan
previously approved these changes
Oct 8, 2024
|
digging all the cleaned code |
vivekschauhan
previously approved these changes
Oct 23, 2024
alrosca
approved these changes
Oct 23, 2024
|
@dgghinea should this have been merged? |
no one did a quick test with this, afaik(apart from testing it myself) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.