Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new features #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

priyagupta20044
Copy link

@priyagupta20044 priyagupta20044 commented Oct 12, 2024

  1. Added dark theme with the help of a new gear icon on the top left with proper margin. Added a new Javascript file that handles the toggle operation for light and dark theme.
  2. Added a profile picture option with a flip card along with introductory texts (can be modified as per will) with shadow and borders
  3. Added smooth transition effects when clicked on the content of navbar by adding smooth scroll
  4. Aligned the introduction text to justify for better look

Attached a video for the reference

https://github.com/user-attachments/assets/86e510bb-e84f-4ad7-90a2-c5416c648f79
solves #8

@Ayu-hack Ayu-hack added good first issue Good for newcomers hacktoberfest-accepted Marks a PR as valid under Hacktoberfest, counting towards participant contributions. labels Oct 13, 2024
@Ayu-hack
Copy link
Owner

Great ! But you can enhance it more.
Add option resume in navbar
And remove the flip transition change it.
Make the portfolio look modern. Or you add another portfolio if you have

@priyagupta20044
Copy link
Author

sure, working on it

@Ayu-hack
Copy link
Owner

Replace MyApp with some name or logo

@Ayu-hack
Copy link
Owner

YOU ARE WORKING ON IT OR NOT ?

@priyagupta20044
Copy link
Author

I need more time, I had completed the previous changes but having continuous exams so I would be requiring time to incorporating changes that you requested the other day.

@Ayu-hack
Copy link
Owner

okay. Take your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest-accepted Marks a PR as valid under Hacktoberfest, counting towards participant contributions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants