Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix for Chat history thread title is saved with space #1436

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

Pavan-Microsoft
Copy link
Contributor

Purpose

Fix for Chat history thread title is saved with space

Bug 9546: [QA] - CWYD - Chat history thread title is saved with space

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

What to Check

Deploy CWYD with GPT 4o
Go to CWYD Admin and enable chat history if not enabled
Go to CWYD web url and save chat history conversations
Click on Show chat history button and click on Edit icon for a chat thread
Remove the text in chat thread title and update with 1 empty space
Click on Tick icon
Expected behavior: Chat thread title should not be saved with empty space
Actual behavior: Chat thread title saved with empty space

Copy link

Coverage

Coverage Report •
FileStmtsMissCoverMissing
code/backend/api
   chat_history.py21017715%24–28, 32–33, 35, 37, 44–47, 49, 51, 55–57, 63, 68–71, 76–78, 80–82, 85–88, 91, 94–95, 100, 102–104, 109–113, 116, 119–120, 122–123, 126–128, 131, 134–135, 145–149, 152, 154–156, 161–163, 165–166, 169, 172–173, 175–176, 179–181, 184, 188–189, 199, 204, 215, 219–221, 226–228, 230, 232, 235, 237–240, 249–251, 254, 257, 259, 268–270, 275–277, 279, 281, 284, 288–290, 292, 295–296, 302, 304, 309, 313, 322–324, 332–334, 336–338, 340–343, 346–348, 351, 354–356, 359, 363–365, 373, 379–380, 382, 384–385, 387, 394, 401, 403, 417–419, 424–427, 432–435, 439, 441, 446, 448–450, 457–460
TOTAL310991570% 

Tests Skipped Failures Errors Time
301 0 💤 0 ❌ 0 🔥 48.475s ⏱️

@Pavan-Microsoft Pavan-Microsoft added this pull request to the merge queue Oct 25, 2024
Merged via the queue into main with commit b587b98 Oct 25, 2024
9 checks passed
@Pavan-Microsoft Pavan-Microsoft deleted the PSL-BUG-9546 branch October 25, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants