Skip to content

Commit

Permalink
Interim checking: TODO markers are changes (#138)
Browse files Browse the repository at this point in the history
  • Loading branch information
nitya authored Jun 17, 2024
1 parent 7d69f94 commit fad8882
Showing 1 changed file with 14 additions and 3 deletions.
17 changes: 14 additions & 3 deletions infra/core/ai/hub.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ param publicNetworkAccess string = 'Enabled'
param location string = resourceGroup().location
param tags object = {}

resource hub 'Microsoft.MachineLearningServices/workspaces@2024-01-01-preview' = {
// NN:TODO resource hub 'Microsoft.MachineLearningServices/workspaces@2024-01-01-preview' = {
resource hub 'Microsoft.MachineLearningServices/workspaces@2024-04-01' = {
name: name
location: location
tags: tags
Expand All @@ -54,6 +55,7 @@ resource hub 'Microsoft.MachineLearningServices/workspaces@2024-01-01-preview' =
discoveryUrl: 'https://${location}.api.azureml.ms/discovery'
}

/* NN:TODO
resource contentSafetyDefaultEndpoint 'endpoints' = {
name: 'Azure.ContentSafety'
properties: {
Expand All @@ -62,16 +64,25 @@ resource hub 'Microsoft.MachineLearningServices/workspaces@2024-01-01-preview' =
associatedResourceId: openAi.id
}
}
*/

resource openAiConnection 'connections' = {
/*
NN:TODO
Connections are not in the GA Swagger - they are only in public preview of 2024-04-01-preview version
That is what you specify with the workspace@ version for AML API version
The ApiVersion specified in the metadata is for the Azure Cognitive Services version (that wraps the OpenAPI call)
*/

resource openAiConnection 'connections@2024-04-01-preview' = { // NN:TODO Add @version to ensure resource is correctly versioned
name: 'aoai-connection'
properties: {
category: 'AzureOpenAI'
authType: 'ApiKey'
isSharedToAll: true
target: openAi.properties.endpoints['OpenAI Language Model Instance API']
metadata: {
ApiVersion: '2023-07-01-preview'
//ApiVersion: '2023-07-01-preview'
ApiVersion: '2024-02-01'
ApiType: 'azure'
ResourceId: openAi.id
}
Expand Down

0 comments on commit fad8882

Please sign in to comment.